/Community

I get a Remove unused internal classes warning on this code:

        static void Main( string[] args )
        {
            IComparable x=GetInfo(typeof(int));
        }

        static private IComparable GetInfo( Type t )
        {
            Type c=typeof(Info<>).MakeGenericType(t);
            return Activator.CreateInstance(c) as IComparable;
        }

        private class Info<T> : IComparable
        {
            public int CompareTo( object obj )
            {
                throw new Exception("The method or operation is not implemented.");
            }
        }

The CodeIt.Right version is 1.6.09156

 Thanks,

Nadav

Hi Nadav,

This is a bug indeed. We fixed it and the fix will be available in the next build.

FYI, the problem was in "typeof(Info<>)" - should it have been something like "typeof(Info<string>)" CodeIt.Right would've not raised the violation.

But, again, this is fixed now.

Thanks for reporting the issue!

No shouldn't. If you want to use MakeGenericType() you need a GenericTypeDefinition.

typeof(Info<>) returns a GenericTypeDefinition.

typeof(Info<string>) returns a GenericType.

Nadav

Hi Nadav,

Sorry for misunderstanding, I did not mean that you should've used "typeof(Info<string>)", not at all. I meant that CodeIt.Right would've parsed "typeof(Info<string>)" correctly but in your case "typeof(Info<>)" - this is where CIR had a hiccup.

Anyway, this is fixed and if you need the new temp build right now before we publicly release it, just let me know, I will make it available to you.

Thanks!